lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 Jul 2014 12:06:20 +0200 From: Sebastian Andrzej Siewior <bigeasy@...utronix.de> To: Tony Lindgren <tony@...mide.com> CC: linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, Felipe Balbi <balbi@...com>, linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org, Greg Kroah-Hartman <gregkh@...uxfoundation.org> Subject: Re: [PATCH 5/5] tty: serial: Add 8250-core based omap driver On 07/17/2014 10:12 AM, Tony Lindgren wrote: > Hmm it could be that it works for a while because the clocks are on > from the bootloader and pm_runtime calls won't do anything. This > could happen if the interconnect data based on the ti,hwmods entry > is not getting matched to the new driver. This gets initialized when > the device entry gets created in omap_device_build_from_dt(). > > Or maybe something now affects the clock aliases? It seems that we > are still missing the clocks entries in the .dtsi files, see the > mappings with $ git grep uart drivers/clk/ti/ I've been looking for something completely different while I noticed this: in drivers/tty/serial/omap-serial.c | static struct platform_driver serial_omap_driver = { | .driver = { | .name = DRIVER_NAME, | }, | }; | and DRIVER_NAME should come from include/linux/platform_data/serial-omap.h Looking further, I've found arch/arm/mach-omap2/serial.c: | void __init omap_serial_init_port(struct omap_board_data *bdata, | struct omap_uart_port_info *info) | { | char *name … | name = DRIVER_NAME; … | pdev = omap_device_build(name, uart->num, oh, pdata, pdata_size); … | Would this explain it? > Regards, > > Tony Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists