lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 Jul 2014 14:51:56 +0300 From: Oded Gabbay <oded.gabbay@....com> To: Joe Perches <joe@...ches.com>, Jerome Glisse <j.glisse@...il.com> CC: David Airlie <airlied@...ux.ie>, Alex Deucher <alexander.deucher@....com>, <linux-kernel@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>, "John Bridgman" <John.Bridgman@....com>, Andrew Lewycky <Andrew.Lewycky@....com>, Joerg Roedel <joro@...tes.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>, Kishon Vijay Abraham I <kishon@...com>, "Sandeep Nair" <sandeep_n@...com>, Kenneth Heitke <kheitke@...eaurora.org>, "Srinivas Pandruvada" <srinivas.pandruvada@...ux.intel.com>, Santosh Shilimkar <santosh.shilimkar@...com>, Andreas Noever <andreas.noever@...il.com>, "Lucas Stach" <l.stach@...gutronix.de>, Philipp Zabel <p.zabel@...gutronix.de> Subject: Re: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for AMD's GPUs On 11/07/14 20:28, Joe Perches wrote: > On Fri, 2014-07-11 at 13:04 -0400, Jerome Glisse wrote: >> On Fri, Jul 11, 2014 at 12:50:09AM +0300, Oded Gabbay wrote: > [] >>> +static long kfd_ioctl(struct file *, unsigned int, unsigned long); >> >> Nitpick, avoid unsigned int just use unsigned. > > I suggest unsigned int is much more common (and better) > than just unsigned. > > $ git grep -P '\bunsigned\s+(?!long|int|short|char)' -- "*.[ch]" | wc -l > 20778 > > $ git grep -P "\bunsigned\s+int\b" -- "*.[ch]" | wc -l > 98068 > So I left it as unsigned int in v2 of the patchset. >>> +static int kfd_open(struct inode *, struct file *); > > It's also generally better to use types and names tno > improve how a human reads and understands the code. > > Fixed in v2 of the patchset. Oded -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists