lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 Jul 2014 17:43:38 +0530 From: Prakash Burla <burlaprakash.linuxkernel@...il.com> To: srinivas.kandagatla@...aro.org Cc: linux@....linux.org.uk, ulf.hansson@...aro.org, linux-mmc@...r.kernel.org, chris@...ntf.net, linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org, linus.walleij@...aro.org Subject: Re: FW: Fwd: [PATCH v6 08/12] mmc: mmci: Add support to data commands via variant structure. tested-by: Prakash Burla <prakash.burla@...rtplayin.com This driver is tested on IFC6410. > From: <srinivas.kandagatla@...aro.org> > Date: Mon, Jun 2, 2014 at 2:39 PM > Subject: [PATCH v6 08/12] mmc: mmci: Add support to data commands via > variant structure. > To: Russell King <linux@....linux.org.uk>, Ulf Hansson > <ulf.hansson@...aro.org>, linux-mmc@...r.kernel.org > Cc: Chris Ball <chris@...ntf.net>, linux-kernel@...r.kernel.org, > linux-arm-msm@...r.kernel.org, linus.walleij@...aro.org, Srinivas > Kandagatla <srinivas.kandagatla@...aro.org> > > > From: Srinivas Kandagatla <srinivas.kandagatla@...aro.org> > > On some SOCs like Qcom there are explicit bits in the command register > to specify if its a data transfer command or not. So this patch adds > support to such bits in variant data, giving more flexibility to the > driver. > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org> > Reviewed-by: Linus Walleij <linus.walleij@...aro.org> > --- > drivers/mmc/host/mmci.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c > index 4c95a9b..8534c29 100644 > --- a/drivers/mmc/host/mmci.c > +++ b/drivers/mmc/host/mmci.c > @@ -59,6 +59,7 @@ static unsigned int fmax = 515633; > * is asserted (likewise for RX) > * @fifohalfsize: number of bytes that can be written when MCI_TXFIFOHALFEMPTY > * is asserted (likewise for RX) > + * @data_cmd_enable: enable value for data commands. > * @sdio: variant supports SDIO > * @st_clkdiv: true if using a ST-specific clock divider algorithm > * @datactrl_mask_ddrmode: ddr mode mask in datactrl register. > @@ -79,6 +80,7 @@ struct variant_data { > unsigned int datalength_bits; > unsigned int fifosize; > unsigned int fifohalfsize; > + unsigned int data_cmd_enable; > unsigned int datactrl_mask_ddrmode; > bool sdio; > bool st_clkdiv; > @@ -839,6 +841,9 @@ mmci_start_command(struct mmci_host *host, struct > mmc_command *cmd, u32 c) > if (/*interrupt*/0) > c |= MCI_CPSM_INTERRUPT; > > + if (mmc_cmd_type(cmd) == MMC_CMD_ADTC) > + c |= host->variant->data_cmd_enable; > + > host->cmd = cmd; > > writel(cmd->arg, base + MMCIARGUMENT); > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists