lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 Jul 2014 16:54:35 +0300 From: Andrey Utkin <andrey.krieger.utkin@...il.com> To: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org Cc: Andrey Utkin <andrey.krieger.utkin@...il.com> Subject: [PATCH 2/4] drivers/message/i2o/i2o_block.c: drop negativity check of unsigned long arg [linux-3.16-rc5/drivers/message/i2o/i2o_block.c:674]: (style) Checking if unsigned variable 'arg' is less than zero. Source code is if (arg < 0 || arg > CACHE_SMARTFETCH) break; but static int i2o_block_ioctl(struct block_device *bdev, fmode_t mode, unsigned int cmd, unsigned long arg) Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80451 Reported-by: David Binderman <dcb314@...mail.com> Signed-off-by: Andrey Utkin <andrey.krieger.utkin@...il.com> --- drivers/message/i2o/i2o_block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/message/i2o/i2o_block.c b/drivers/message/i2o/i2o_block.c index 6fc3866..2b684ec 100644 --- a/drivers/message/i2o/i2o_block.c +++ b/drivers/message/i2o/i2o_block.c @@ -671,7 +671,7 @@ static int i2o_block_ioctl(struct block_device *bdev, fmode_t mode, break; case BLKI2OSRSTRAT: ret = -EINVAL; - if (arg < 0 || arg > CACHE_SMARTFETCH) + if (arg > CACHE_SMARTFETCH) break; dev->rcache = arg; ret = 0; -- 1.8.5.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists