linux-kernel - Re: [patch] mm: memcontrol: use page lists for uncharge batching

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140717152936.GF8011@dhcp22.suse.cz>
Date:	Thu, 17 Jul 2014 17:29:36 +0200
From:	Michal Hocko <mhocko@...e.cz>
To:	Johannes Weiner <hannes@...xchg.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Hugh Dickins <hughd@...gle.com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [patch] mm: memcontrol: use page lists for uncharge batching

On Mon 07-07-14 14:55:58, Johannes Weiner wrote:
> Pages are now uncharged at release time, and all sources of batched
> uncharges operate on lists of pages.  Directly use those lists, and
> get rid of the per-task batching state.
> 
> This also batches statistics accounting, in addition to the res
> counter charges, to reduce IRQ-disabling and re-enabling.

It is probably worth noticing that there is a higher chance of missing
threshold events now when we can accumulate huge number of uncharges
during munmaps. I do not think this is earth shattering and the overall
improvement is worth it but changelog should mention it.

> Signed-off-by: Johannes Weiner <hannes@...xchg.org>

With the follow up fix from
http://marc.info/?l=linux-mm&m=140552814228135&w=2

Acked-by: Michal Hocko <mhocko@...e.cz>

one nit below.

[...]
> +static void uncharge_list(struct list_head *page_list)
> +{
> +	struct mem_cgroup *memcg = NULL;
> +	unsigned long nr_memsw = 0;
> +	unsigned long nr_anon = 0;
> +	unsigned long nr_file = 0;
> +	unsigned long nr_huge = 0;
> +	unsigned long pgpgout = 0;
> +	unsigned long nr_mem = 0;
> +	struct list_head *next;
> +	struct page *page;
> +
> +	next = page_list->next;
> +	do {

I would use list_for_each_entry here which would also save list_empty
check in mem_cgroup_uncharge_list

> +		unsigned int nr_pages = 1;
> +		struct page_cgroup *pc;
> +
> +		page = list_entry(next, struct page, lru);
> +		next = page->lru.next;
> +
> +		VM_BUG_ON_PAGE(PageLRU(page), page);
> +		VM_BUG_ON_PAGE(page_count(page), page);
> +
> +		pc = lookup_page_cgroup(page);
> +		if (!PageCgroupUsed(pc))
> +			continue;
> +
> +		/*
> +		 * Nobody should be changing or seriously looking at
> +		 * pc->mem_cgroup and pc->flags at this point, we have
> +		 * fully exclusive access to the page.
> +		 */
> +
> +		if (memcg != pc->mem_cgroup) {
> +			if (memcg) {
> +				uncharge_batch(memcg, pgpgout, nr_mem, nr_memsw,
> +					       nr_anon, nr_file, nr_huge, page);
> +				pgpgout = nr_mem = nr_memsw = 0;
> +				nr_anon = nr_file = nr_huge = 0;
> +			}
> +			memcg = pc->mem_cgroup;
> +		}
> +
> +		if (PageTransHuge(page)) {
> +			nr_pages <<= compound_order(page);
> +			VM_BUG_ON_PAGE(!PageTransHuge(page), page);
> +			nr_huge += nr_pages;
> +		}
> +
> +		if (PageAnon(page))
> +			nr_anon += nr_pages;
> +		else
> +			nr_file += nr_pages;
> +
> +		if (pc->flags & PCG_MEM)
> +			nr_mem += nr_pages;
> +		if (pc->flags & PCG_MEMSW)
> +			nr_memsw += nr_pages;
> +		pc->flags = 0;
> +
> +		pgpgout++;
> +	} while (next != page_list);
> +
> +	if (memcg)
> +		uncharge_batch(memcg, pgpgout, nr_mem, nr_memsw,
> +			       nr_anon, nr_file, nr_huge, page);
> +}
-- 
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/