lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 16 Jul 2014 22:53:43 -0400 From: Sasha Levin <sashal@...nel.org> To: Nick Krause <xerofoify@...il.com>, Joe Perches <joe@...ches.com> CC: Andrew Morton <akpm@...ux-foundation.org>, josh@...htriplett.org, robh@...nel.org, florian.vaussard@...l.ch, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: Checkpatch Feature Idea: Search directory for files with errors and warnings with -d argument On 07/16/2014 12:59 AM, Nick Krause wrote: > On Wed, Jul 16, 2014 at 12:39 AM, Joe Perches <joe@...ches.com> wrote: >> > On Wed, 2014-07-16 at 00:28 -0400, Nick Krause wrote: >>> >> I am cleaning up the kernel as it needs a lot of cleanup. >> > >> > Needs are curious things. >> > >> > Consistency is a nicety not really a need. >> > >> > Bugs need fixing. Defects need eliminating. >> > Enhancements are appreciated. Inconsistent >> > code style is a minor annoyance. >> > >> > I suggest you focus on the bugs, defects or >> > enhancements in performance or testing. >> > >> > Are you really cross-compiling the patches you >> > submit here or do you have an alpha on your desk? >> > >> > > I am cross compiling then. I don't have the hardware :(. Are you sure you're actually cross compiling them? From your recent patchset it doesn't seem you even bother to do that: diff --git a/arch/alpha/boot/misc.c b/arch/alpha/boot/misc.c index 174b7c6..886e469 100644 --- a/arch/alpha/boot/misc.c +++ b/arch/alpha/boot/misc.c @@ -23,7 +23,7 @@ #include <asm/uaccess.h> -#define memzero (s, n) memset((s), 0 , (n)) +#define memzero { (s, n) memset((s), 0 , (n)) } #define puts srm_printk extern long srm_printk(const char *, ...) __attribute__ ((format (printf, 1, 2))); @@ -61,8 +61,8 @@ static unsigned outcnt; /* bytes in output buffer */ /* Diagnostic functions */ #ifdef DEBUG -# define Assert (cond, msg) {if (!(cond)) error(msg) ; } -# define Trace(x) fprintf x +# define Assert { (cond, msg) {if (!(cond)) error(msg) ; } } +# define Trace { (x) fprintf x } # define Tracev(x) {if (verbose) fprintf x ; } # define Tracevv(x) {if (verbose > 1) fprintf x ; } # define Tracec(c, x) {if (verbose && (c)) fprintf x ; } Or: diff --git a/arch/alpha/boot/misc.c b/arch/alpha/boot/misc.c index 886e469..56c3325 100644 --- a/arch/alpha/boot/misc.c +++ b/arch/alpha/boot/misc.c @@ -144,7 +144,7 @@ static void error(char *x) puts(x); puts("\n\n -- System halted"); - while (1); + while{ (1); } /* Halt */ } Thanks, Sasha -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists