lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 Jul 2014 12:01:52 -0700 From: Zach Brown <zab@...bo.net> To: Fabian Frederick <fabf@...net.be> Cc: Josef Bacik <jbacik@...com>, linux-kernel@...r.kernel.org, linux-btrfs@...r.kernel.org, Chris Mason <clm@...com> Subject: Re: [PATCH 1/1] Btrfs: fix sparse warning > > > @@ -515,7 +515,8 @@ static int write_buf(struct file *filp, const void *buf, > > > u32 len, loff_t *off) > > > > Though this probably wants to be rewritten in terms of kernel_write(). > > That'd give an opportunity to get rid of the sctx->send_off and have it > > use f_pos in the filp. > > Do you mean directly call kernel_write from send_cmd/send_header ? > I guess that loop around vfs_write in write_buf is there for something ... write_buf() could still exist to iterate over the buffer in the case of partial writes but it doesn't need to muck around with set_fs() and forcing casts. - z -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists