linux-kernel - Re: [PATCH 1/4] drivers/hsi/controllers/omap_ssi{,

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 17 Jul 2014 22:51:15 +0200
From:	Sebastian Reichel <sre@...nel.org>
To:	Andrey Utkin <andrey.krieger.utkin@...il.com>
Cc:	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	arnd@...db.de, carlos.chinea@...ia.com
Subject: Re: [PATCH 1/4] drivers/hsi/controllers/omap_ssi{,_port}.c: fix
 failure checks

Hi,

On Thu, Jul 17, 2014 at 04:53:54PM +0300, Andrey Utkin wrote:
> 1.
> 
> [linux-3.16-rc5/drivers/hsi/controllers/omap_ssi.c:357]: (style) Checking if
> unsigned variable 'gdd_irq' is less than zero.
> 
> Source code is
> 
>     omap_ssi->gdd_irq = platform_get_irq_byname(pd, "gdd_mpu");
>     if (omap_ssi->gdd_irq < 0) {
> 
> 2.
> 
> [linux-3.16-rc5/drivers/hsi/controllers/omap_ssi_port.c:1017]: (style) Checking
> if unsigned variable 'irq' is less than zero.
> 
> Source code is
> 
>     omap_port->irq = platform_get_irq(pd, 0);
>     if (omap_port->irq < 0) {
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80441
> Reported-by: David Binderman <dcb314@...mail.com>
> Signed-off-by: Andrey Utkin <andrey.krieger.utkin@...il.com>

applied to my for-next branch:

https://git.kernel.org/cgit/linux/kernel/git/sre/linux-hsi.git/commit/?h=for-next&id=b74d4954ae6a6799f7ee832bc377795ab506f4b1

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)