linux-kernel - Re: [PATCH] checkpatch.pl: Remove --file option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1407180039510.24854@nanos>
Date:	Fri, 18 Jul 2014 00:43:06 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Joe Perches <joe@...ches.com>
cc:	Richard Weinberger <richard@....at>, akpm@...ux-foundation.org,
	apw@...onical.com, tytso@....edu, dwalter@...gle.com, bp@...e.de,
	neilb@...e.de, hch@...radead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch.pl: Remove --file option

On Thu, 17 Jul 2014, Joe Perches wrote:

> On Thu, 2014-07-17 at 17:34 +0200, Richard Weinberger wrote:
> > checkpatch.pl is a nice tool to find issues in patches.
> 
> grep is a similar tool, just less automated.
> 
> > Sadly this tool gets more and more abused by various people to create
> > style cleanups for source files within the kernel.
> > In order to deal with that bad habit let's remove the --file option
> > and bring checkpatch.pl back to its original purpose.
> 
> Any tool can be misused.
> 
> diff -urN /dev/null $file | ./scripts/checkpatch.pl -
> 
> does the same thing as --file so I don't see any real
> fundamental difference.

There is a fundamental difference:

Coming up with the above requires actual brain involvement.

./scripts/checkpatch.pl -f

not so much.

So, for Richards patch:

Acked-and-heartely-welcomed-by: Thomas Gleixner <tglx@...utronix.de>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/