lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140717143435.2fc69837@notabene.brown>
Date: Thu, 17 Jul 2014 14:34:35 +1000
From: NeilBrown <neilb@...e.de>
To: Ian Kent <raven@...maw.net>
Cc: autofs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/6 v2] autofs4: factor should_expire() out of
autofs4_expire_indirect.
On Wed, 16 Jul 2014 15:50:17 +0800 Ian Kent <raven@...maw.net> wrote:
> > + if (simple_empty(dentry))
> > + return NULL;
> > +
> > + /* Case 2: tree mount, expire iff entire tree is not busy */
> > + if (!exp_leaves) {
> > + /* Path walk currently on this dentry? */
> > + ino_count = atomic_read(&ino->count) + 1;
> > + if (d_count(dentry) > ino_count)
> > + return NULL;
> > +
> > + if (!autofs4_tree_busy(mnt, dentry, timeout, do_now))
> > + return dentry;
> > + /*
> > + * Case 3: pseudo direct mount, expire individual leaves
> > + * (autofs-4.1).
> > + */
>
> I recommend removing one of the tab stops on this since it relates to
> the else case but feels like it's "attached" to the code above the else.
The auto-reindent feature of emacs put it there and I didn't double check.
I've fix it.
>
> > + } else {
> > + /* Path walk currently on this dentry? */
> > + struct dentry *expired;
> > + ino_count = atomic_read(&ino->count) + 1;
> > + if (d_count(dentry) > ino_count)
> > + return NULL;
> > +
> > + expired = autofs4_check_leaves(mnt, dentry, timeout, do_now);
> > + if (expired) {
> > + if (expired == dentry)
> > + dput(dentry);
> > + return dentry;
>
> Umm .. I think this should be "return expired".
Yes, of course it should. Fixed.
>
> Otherwise this looks like a straight refactor.
Thanks,
NeilBrown
Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)
Powered by blists - more mailing lists