linux-kernel - Re: [PATCH] parisc: Remove FIXME comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53C98860.2010905@gmx.de>
Date:	Fri, 18 Jul 2014 22:49:36 +0200
From:	Helge Deller <deller@....de>
To:	Nicholas Krause <xerofoify@...il.com>, jejb@...isc-linux.org
CC:	tiwai@...e.de, jkosina@...e.cz, joe@...ches.com,
	dave.anglin@...l.net, linux-parisc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] parisc: Remove FIXME comment

On 07/18/2014 10:37 PM, Nicholas Krause wrote:
> The comment for size of frame not being needed is incorrect , the
> function called needs this parameter.

Thanks for the patch Nicholas.

It has been queued up:
https://patchwork.kernel.org/patch/4587631/
and
https://patchwork.kernel.org/patch/4486231/

I will apply it at some point, but not yet.
There are other (more important) patches upcoming regarding the 
signal handling,  and I don't want to break those at the moment.

Helge

> 
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> ---
>  arch/parisc/kernel/signal.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/parisc/kernel/signal.c b/arch/parisc/kernel/signal.c
> index 1cba8f2..1d550b5 100644
> --- a/arch/parisc/kernel/signal.c
> +++ b/arch/parisc/kernel/signal.c
> @@ -240,7 +240,6 @@ setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info,
>  #endif
>  	
>  	usp = (regs->gr[30] & ~(0x01UL));
> -	/*FIXME: frame_size parameter is unused, remove it. */
>  	frame = get_sigframe(ka, usp, sizeof(*frame));
>  
>  	DBG(1,"SETUP_RT_FRAME: START\n");
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/