linux-kernel - Re: [PATCH] Staging: gdm724x: gdm_lte.c: fix missing blank line after variable declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140718010536.GA28618@kroah.com>
Date:	Thu, 17 Jul 2014 18:05:36 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Kiran Padwal <kiran.padwal21@...il.com>
Cc:	devel@...verdev.osuosl.org, gulsah.1004@...il.com,
	wkang77@...il.com, rusty@...tcorp.com.au,
	valentina.manea.m@...il.com, linux-kernel@...r.kernel.org,
	rashika.kheria@...il.com
Subject: Re: [PATCH] Staging: gdm724x: gdm_lte.c: fix missing blank line
 after variable declaration

On Thu, Jul 17, 2014 at 09:30:38AM +0530, Kiran Padwal wrote:
> Checkpatch fix - Add missing blank line after variable declaration
> 
> Signed-off-by: Kiran Padwal <kiran.padwal21@...il.com>
> ---
>  drivers/staging/gdm724x/gdm_lte.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/gdm724x/gdm_lte.c b/drivers/staging/gdm724x/gdm_lte.c
> index 64c55b9..bc6d574 100644
> --- a/drivers/staging/gdm724x/gdm_lte.c
> +++ b/drivers/staging/gdm724x/gdm_lte.c
> @@ -447,6 +447,7 @@ static int gdm_lte_tx(struct sk_buff *skb, struct net_device *dev)
>  	 */
>  	if (nic_type & NIC_TYPE_F_VLAN) {
>  		struct vlan_ethhdr *vlan_eth = (struct vlan_ethhdr *)skb->data;
> +
>  		nic->vlan_id = ntohs(vlan_eth->h_vlan_TCI) & VLAN_VID_MASK;
>  		data_buf = skb->data + (VLAN_ETH_HLEN - ETH_HLEN);
>  		data_len = skb->len - (VLAN_ETH_HLEN - ETH_HLEN);
> @@ -505,6 +506,7 @@ static int gdm_lte_tx(struct sk_buff *skb, struct net_device *dev)
>  static struct net_device_stats *gdm_lte_stats(struct net_device *dev)
>  {
>  	struct nic *nic = netdev_priv(dev);
> +
>  	return &nic->stats;
>  }
>  

Someone else sent me this same patch back in May, and it's in my tree.
Please always work against linux-next, or my staging-next branch of my
staging.git tree if you want to send me patches like this.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/