linux-kernel - Re: [PATCH 2/3] blk-mq: pass along blk_mq_alloc_tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140718094559.GB2121@lst.de>
Date:	Fri, 18 Jul 2014 11:45:59 +0200
From:	Christoph Hellwig <hch@....de>
To:	Robert Elliott <elliott@...com>
Cc:	axboe@...nel.dk, abhijit.mahajan@...gotech.com, kmo@...arainc.com,
	nagalakshmi.nandigama@...gotech.com, asamymuthupa@...ron.com,
	snitzer@...hat.com, JBottomley@...allels.com,
	relliott@...rdog.cce.hp.com, sreekanth.reddy@...gotech.com,
	praveen.krishnamoorthy@...gotech.com, agordeev@...hat.com,
	scameron@...rdog.cce.hp.com, tom.leiming@...il.com,
	sbradshaw@...ron.com, hch@....de, m@...rling.me,
	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org
Subject: Re: [PATCH 2/3] blk-mq: pass along blk_mq_alloc_tag_set return
	values

On Thu, Jul 17, 2014 at 02:39:21PM -0500, Robert Elliott wrote:
> Two of the blk-mq based drivers do not pass back the return value
> from blk_mq_alloc_tag_set, instead just returning -ENOMEM.
> 
> blk_mq_alloc_tag_set returns -EINVAL if the number of queues or
> queue depth is bad.  -ENOMEM implies that retrying after freeing some
> memory might be more successful, but that won't ever change
> in the -EINVAL cases.
> 
> Change the null_blk and mtip32xx drivers to pass along
> the return value.
> 
> Signed-off-by: Robert Elliott <elliott@...com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@....de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/