linux-kernel - [tip:perf/urgent] kprobes: Fix "Failed to find blacklist" probing errors on ia64 and ppc64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-d81b4253b0f0f1e7b7e03b0cd0f80cab18bc4d7b@git.kernel.org>
Date:	Fri, 18 Jul 2014 03:21:26 -0700
From:	tip-bot for Masami Hiramatsu <tipbot@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	mingo@...nel.org, torvalds@...ux-foundation.org,
	rusty@...tcorp.com.au, mpe@...erman.id.au, tony.luck@...el.com,
	arnd@...db.de, jeremy@...p.org, tglx@...utronix.de,
	linux-kernel@...r.kernel.org, hpa@...or.com, paulus@...ba.org,
	haokexin@...il.com, tony.luck@...il.com, davem@...emloft.net,
	ananth@...ibm.com, masami.hiramatsu.pt@...achi.com,
	benh@...nel.crashing.org, suzuki@...ibm.com, chrisw@...s-sol.org,
	fenghua.yu@...el.com
Subject: [tip:perf/urgent] kprobes: Fix "Failed to find blacklist"
  probing errors on ia64 and ppc64

Commit-ID:  d81b4253b0f0f1e7b7e03b0cd0f80cab18bc4d7b
Gitweb:     http://git.kernel.org/tip/d81b4253b0f0f1e7b7e03b0cd0f80cab18bc4d7b
Author:     Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
AuthorDate: Thu, 17 Jul 2014 11:44:11 +0000
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Fri, 18 Jul 2014 06:23:40 +0200

kprobes: Fix "Failed to find blacklist" probing errors on ia64 and ppc64

On ia64 and ppc64, function pointers do not point to the
entry address of the function, but to the address of a
function descriptor (which contains the entry address and misc
data).

Since the kprobes code passes the function pointer stored
by NOKPROBE_SYMBOL() to kallsyms_lookup_size_offset() for
initalizing its blacklist, it fails and reports many errors,
such as:

  Failed to find blacklist 0001013168300000
  Failed to find blacklist 0001013000f0a000
  [...]

To fix this bug, use arch_deref_entry_point() to get the
function entry address for kallsyms_lookup_size_offset()
instead of the raw function pointer.

Suzuki also pointed out that blacklist entries should also
be updated as well.

Reported-by: Tony Luck <tony.luck@...il.com>
Fixed-by: Suzuki K. Poulose <suzuki@...ibm.com>
Tested-by: Tony Luck <tony.luck@...el.com>
Tested-by: Michael Ellerman <mpe@...erman.id.au>
Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
Acked-by: Michael Ellerman <mpe@...erman.id.au> (for powerpc)
Acked-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc: Jeremy Fitzhardinge <jeremy@...p.org>
Cc: sparse@...isli.org
Cc: Paul Mackerras <paulus@...ba.org>
Cc: akataria@...are.com
Cc: anil.s.keshavamurthy@...el.com
Cc: Fenghua Yu <fenghua.yu@...el.com>
Cc: Arnd Bergmann <arnd@...db.de>
Cc: Rusty Russell <rusty@...tcorp.com.au>
Cc: Chris Wright <chrisw@...s-sol.org>
Cc: yrl.pp-manager.tt@...achi.com
Cc: Kevin Hao <haokexin@...il.com>
Cc: Ananth N Mavinakayanahalli <ananth@...ibm.com>
Cc: rdunlap@...radead.org
Cc: dl9pf@....de
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: David S. Miller <davem@...emloft.net>
Cc: linux-ia64@...r.kernel.org
Cc: linuxppc-dev@...ts.ozlabs.org
Link: http://lkml.kernel.org/r/20140717114411.13401.2632.stgit@kbuild-fedora.novalocal
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 kernel/kprobes.c | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/kernel/kprobes.c b/kernel/kprobes.c
index 3214289..734e9a7 100644
--- a/kernel/kprobes.c
+++ b/kernel/kprobes.c
@@ -2037,19 +2037,23 @@ static int __init populate_kprobe_blacklist(unsigned long *start,
 {
 	unsigned long *iter;
 	struct kprobe_blacklist_entry *ent;
-	unsigned long offset = 0, size = 0;
+	unsigned long entry, offset = 0, size = 0;
 
 	for (iter = start; iter < end; iter++) {
-		if (!kallsyms_lookup_size_offset(*iter, &size, &offset)) {
-			pr_err("Failed to find blacklist %p\n", (void *)*iter);
+		entry = arch_deref_entry_point((void *)*iter);
+
+		if (!kernel_text_address(entry) ||
+		    !kallsyms_lookup_size_offset(entry, &size, &offset)) {
+			pr_err("Failed to find blacklist at %p\n",
+				(void *)entry);
 			continue;
 		}
 
 		ent = kmalloc(sizeof(*ent), GFP_KERNEL);
 		if (!ent)
 			return -ENOMEM;
-		ent->start_addr = *iter;
-		ent->end_addr = *iter + size;
+		ent->start_addr = entry;
+		ent->end_addr = entry + size;
 		INIT_LIST_HEAD(&ent->list);
 		list_add_tail(&ent->list, &kprobe_blacklist);
 	}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/