linux-kernel - Re: [tip:locking/urgent] locking/mutex: Disable optimistic spinning on some architectures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1405652857.21735.7.camel@buesod1.americas.hpqcorp.net>
Date:	Thu, 17 Jul 2014 20:07:37 -0700
From:	Davidlohr Bueso <davidlohr@...com>
To:	mingo@...nel.org, torvalds@...ux-foundation.org,
	catalin.marinas@....com, peterz@...radead.org, cmetcalf@...era.com,
	jason.low2@...com, linux@....linux.org.uk, tglx@...utronix.de,
	linux-kernel@...r.kernel.org, hpa@...or.com, dave.anglin@...l.net,
	James.Bottomley@...senpartnership.com, will.deacon@....com,
	waiman.long@...com, james.hogan@...tec.com, mpatocka@...hat.com,
	davem@...emloft.net, paulmck@...ux.vnet.ibm.com,
	vgupta@...opsys.com, benh@...nel.crashing.org,
	jejb@...isc-linux.org
Cc:	linux-tip-commits@...r.kernel.org, stable@...nel.org
Subject: Re: [tip:locking/urgent] locking/mutex: Disable optimistic spinning
 on some architectures

On Wed, 2014-07-16 at 12:24 -0700, tip-bot for Peter Zijlstra wrote:
> Commit-ID:  4badad352a6bb202ec68afa7a574c0bb961e5ebc
> Gitweb:     http://git.kernel.org/tip/4badad352a6bb202ec68afa7a574c0bb961e5ebc
> Author:     Peter Zijlstra <peterz@...radead.org>
> AuthorDate: Fri, 6 Jun 2014 19:53:16 +0200
> Committer:  Ingo Molnar <mingo@...nel.org>
> CommitDate: Wed, 16 Jul 2014 14:57:07 +0200
> 
> locking/mutex: Disable optimistic spinning on some architectures
> 
> The optimistic spin code assumes regular stores and cmpxchg() play nice;
> this is found to not be true for at least: parisc, sparc32, tile32,
> metag-lock1, arc-!llsc and hexagon.
> 
> There is further wreckage, but this in particular seemed easy to
> trigger, so blacklist this.
> 
> Opt in for known good archs.
> 
> Signed-off-by: Peter Zijlstra <peterz@...radead.org>
> Reported-by: Mikulas Patocka <mpatocka@...hat.com>
> Cc: David Miller <davem@...emloft.net>
> Cc: Chris Metcalf <cmetcalf@...era.com>
> Cc: James Bottomley <James.Bottomley@...senpartnership.com>
> Cc: Vineet Gupta <vgupta@...opsys.com>
> Cc: Jason Low <jason.low2@...com>
> Cc: Waiman Long <waiman.long@...com>
> Cc: "James E.J. Bottomley" <jejb@...isc-linux.org>
> Cc: Paul McKenney <paulmck@...ux.vnet.ibm.com>
> Cc: John David Anglin <dave.anglin@...l.net>
> Cc: James Hogan <james.hogan@...tec.com>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> Cc: Davidlohr Bueso <davidlohr@...com>
> Cc: stable@...r.kernel.org
> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> Cc: Catalin Marinas <catalin.marinas@....com>
> Cc: Russell King <linux@....linux.org.uk>
> Cc: Will Deacon <will.deacon@....com>
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-kernel@...r.kernel.org
> Cc: linuxppc-dev@...ts.ozlabs.org
> Cc: sparclinux@...r.kernel.org
> Link: http://lkml.kernel.org/r/20140606175316.GV13930@laptop.programming.kicks-ass.net
> Signed-off-by: Ingo Molnar <mingo@...nel.org>

Cc'ing stable: this issue was reported to begin after commit fb0527bd,
so since v3.13.

Thanks,
Davidlohr

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/