linux-kernel - Re: [PATCH v2 2/6] printk: LOG_CONT and LOG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53C92396.2080007@linaro.org>
Date:	Fri, 18 Jul 2014 08:39:34 -0500
From:	Alex Elder <elder@...aro.org>
To:	Petr Mládek <pmladek@...e.cz>
CC:	akpm@...ux-foundation.org, bp@...e.de, john.stultz@...aro.org,
	jack@...e.cz, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/6] printk: LOG_CONT and LOG_NEWLINE are opposites

On 07/18/2014 05:53 AM, Petr Mládek wrote:
>> @@ -1686,9 +1690,8 @@ asmlinkage int vprintk_emit(int facility, int level,
>> >  		if (cont_add(facility, level, text, text_len))
>> >  			printed_len += text_len;
>> >  		else
>> > -			printed_len += log_store(facility, level,
>> > -						 lflags | LOG_CONT, 0,
>> > -						 dict, dictlen, text, text_len);
>> > +			printed_len += log_store(facility, level, lflags, 0,
>> > +						 NULL, 0, text, text_len);
>> >  	} else {
>> >  		bool stored = false;
>> >  
> I do not see real benefit in this change. I think that it would cause
> more confusion than help. I would suggest to remove it. Then I will
> agree with this patch :-)

Done.  I'm going to add your Reviewed-by based on this.  Please correct
me if that's not what you want.

					-Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/