linux-kernel - Re: hcd.c Fix me statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDOMVhzpoC2UBnmowzG7yX7kES2NJDGyS9_iXhVaQ=bnXs91g@mail.gmail.com>
Date:	Fri, 18 Jul 2014 13:19:01 -0400
From:	Nick Krause <xerofoify@...il.com>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	Greg KH <gregkh@...uxfoundation.org>, mail@...ermatthias.de,
	hdegoede@...hat.com, sarah.a.sharp@...ux.intel.com,
	dan.j.williams@...el.com, valentine.barshak@...entembedded.com,
	Ming Lei <ming.lei@...onical.com>,
	Michael Opdenacker <michael.opdenacker@...e-electrons.com>,
	linux-usb@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: hcd.c Fix me statements

On Fri, Jul 18, 2014 at 10:45 AM, Alan Stern <stern@...land.harvard.edu> wrote:
> On Fri, 18 Jul 2014, Nick Krause wrote:
>
>> I am assuming this is a stupid question but since I am new I will ask it anyway.
>> Can the  usb_bus  structure be Null? If can I will send it a patch removing the
>> fix mes on  lines 854 and 878 of hcd.c .
>
> Line numbers in a source file usually aren't very useful.  They're
> different in every version of the kernel.  Instead just mention which
> functions you're talking about.  It looks like
> authorized_default_show() and authorized_default_store().
>
> Yes, it's true that usb_bus (which is a pointer, not a structure) can
> never be NULL.
>
> Alan Stern
>

If that is the case I will send a patch, removing the lines as it
seems we don't need to check for NULL then based
on your information.
Cheers Nick
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/