linux-kernel - Re: [PATCH v3 1/7] printk: report dropped messages on separate line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53C973B8.9060900@linaro.org>
Date:	Fri, 18 Jul 2014 14:21:28 -0500
From:	Alex Elder <elder@...aro.org>
To:	akpm@...ux-foundation.org
CC:	kay@...y.org, pmladek@...e.cz, bp@...e.de, john.stultz@...aro.org,
	jack@...e.cz, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/7] printk: report dropped messages on separate line

On 07/18/2014 09:14 AM, Alex Elder wrote:
> It is possible for the log to be filled too quickly for the consoles
> to be able to keep up.  This is detected in console_unlock(), and
> when it occurs, a message is printed on the console.  When reviewing
> some nearby code, Petr Mládek suggested it might be nicer if this
> message were placed on a separate line.  This patch implements that
> suggestion.
> 
> Suggested-by: Petr Mládek <pmladek@...e.cz>
> Signed-off-by: Alex Elder <elder@...aro.org>
> ---
>  kernel/printk/printk.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
> index 13e839d..bed8f09 100644
> --- a/kernel/printk/printk.c
> +++ b/kernel/printk/printk.c
> @@ -2142,9 +2142,10 @@ again:
>  		}
>  
>  		if (console_seq < log_first_seq) {
> -			len = sprintf(text, "** %u printk messages dropped ** ",
> +			len = sprintf(text,
> +				      "%s** %llu printk messages dropped **\n",
                                             ^^^
This is wrong, an artifact I didn't clean up.
It should still just be "%u".  Sorry about that.

					-Alex

> +				      (console_prev & LOG_CONT) ? "\n" : "",
>  				      (unsigned)(log_first_seq - console_seq));
> -
>  			/* messages are gone, move to first one */
>  			console_seq = log_first_seq;
>  			console_idx = log_first_idx;
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/