linux-kernel - Re: [PATCH] usb-core: Remove Fix mes in file hcd.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 18 Jul 2014 15:55:02 -0400
From:	Nick Krause <xerofoify@...il.com>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	Greg KH <gregkh@...uxfoundation.org>, mail@...ermatthias.de,
	hdegoede@...hat.com, dan.j.williams@...el.com,
	valentine.barshak@...entembedded.com,
	Ming Lei <ming.lei@...onical.com>,
	Michael Opdenacker <michael.opdenacker@...e-electrons.com>,
	linux-usb@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb-core: Remove Fix mes in file hcd.c

On Fri, Jul 18, 2014 at 3:09 PM, Alan Stern <stern@...land.harvard.edu> wrote:
> On Fri, 18 Jul 2014, Nicholas Krause wrote:
>
>> I am removing two fix mes in this file as after dicussing then it  seems
>> there is no reason to check against Null for usb_device as it can never
>> be NULL and this is check is therefore not needed.
>>
>> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
>> ---
>>  drivers/usb/core/hcd.c | 4 ----
>>  1 file changed, 4 deletions(-)
>>
>> diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
>> index bec31e2..487abcf 100644
>> --- a/drivers/usb/core/hcd.c
>> +++ b/drivers/usb/core/hcd.c
>> @@ -855,8 +855,6 @@ static ssize_t authorized_default_show(struct device *dev,
>>       struct usb_bus *usb_bus = rh_usb_dev->bus;
>>       struct usb_hcd *usb_hcd;
>>
>> -     if (usb_bus == NULL)    /* FIXME: not sure if this case is possible */
>> -             return -ENODEV;
>>       usb_hcd = bus_to_hcd(usb_bus);
>>       return snprintf(buf, PAGE_SIZE, "%u\n", usb_hcd->authorized_default);
>>  }
>> @@ -871,8 +869,6 @@ static ssize_t authorized_default_store(struct device *dev,
>>       struct usb_bus *usb_bus = rh_usb_dev->bus;
>>       struct usb_hcd *usb_hcd;
>>
>> -     if (usb_bus == NULL)    /* FIXME: not sure if this case is possible */
>> -             return -ENODEV;
>>       usb_hcd = bus_to_hcd(usb_bus);
>>       result = sscanf(buf, "%u\n", &val);
>>       if (result == 1) {
>
> Acked-by: Alan Stern <stern@...land.harvard.edu>
>
Great to hear this is going through :).
Nick
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/