lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 18 Jul 2014 22:52:08 -0400
From:	Nick Krause <xerofoify@...il.com>
To:	Sasha Levin <sashal@...nel.org>
Cc:	Greg KH <gregkh@...uxfoundation.org>,
	Alan Stern <stern@...land.harvard.edu>, mail@...ermatthias.de,
	hdegoede@...hat.com, dan.j.williams@...el.com,
	valentine.barshak@...entembedded.com,
	Ming Lei <ming.lei@...onical.com>,
	Michael Opdenacker <michael.opdenacker@...e-electrons.com>,
	linux-usb@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb-core: Remove Fix mes in file hcd.c

On Fri, Jul 18, 2014 at 10:45 PM, Nick Krause <xerofoify@...il.com> wrote:
> Sorry didn't run spell check. I will resend this patch with the
> correct information
> as needed. Thanks for the advice, Sasha.
>
> Cheers Nick
>
> On Fri, Jul 18, 2014 at 10:36 PM, Sasha Levin <sashal@...nel.org> wrote:
>> On 07/18/2014 01:34 PM, Nicholas Krause wrote:
>>> I am removing two fix mes in this file as after dicussing then it  seems
>>> there is no reason to check against Null for usb_device as it can never
>>> be NULL and this is check is therefore not needed.
>>>
>>> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
>>
>> Please explain exactly why it's not needed, why it can never be NULL, and
>> what prevents it from being NULL.
>>
>> "after dicussing" (do you run spellcheck on your mails?) won't mean anything
>> to someone looking at this commit in a year.
>>
>> Your commit message also mentions usb_device which has nothing to do with
>> your patch.
>>
>>
>> Thanks,
>> Sasha

Sasha ,
Greg seems to have signed it off.
Cheers Nick
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists