linux-kernel - Re: [PATCH] parisc: Remove FIXME comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDOMVhKZsjKn8BDq-epTkqZ4oByFtyCwuxqrSGcvMhB3+ATOA@mail.gmail.com>
Date:	Sat, 19 Jul 2014 01:28:22 -0400
From:	Nick Krause <xerofoify@...il.com>
To:	James Bottomley <James.Bottomley@...senpartnership.com>
Cc:	deller@....de, tiwai@...e.de, Jiri Kosina <jkosina@...e.cz>,
	Joe Perches <joe@...ches.com>, dave.anglin@...l.net,
	linux-parisc@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] parisc: Remove FIXME comment

On Sat, Jul 19, 2014 at 1:20 AM, James Bottomley
<James.Bottomley@...senpartnership.com> wrote:
> On Fri, 2014-07-18 at 22:25 -0400, Nick Krause wrote:
>> On Fri, Jul 18, 2014 at 5:03 PM, James Bottomley
>> <James.Bottomley@...senpartnership.com> wrote:
>> > On Fri, 2014-07-18 at 16:37 -0400, Nicholas Krause wrote:
>> >> The comment for size of frame not being needed is incorrect , the
>> >> function called needs this parameter.
>> >
>> > Actually, that's not correct.  The point of the FIXME is that fram_size
>> > is only used in a debug print and could be eliminated since the
>> > internals of the function excluding the debugging statements don't use
>> > it.
>> >
>> > James
>> >
>> >
>>
>> So I need to need a patch removing the parameter from the  function
>> and this part of the code?
>
> Well, no, I'm not sure there's any action to take.  The FIXME reminds us
> that there's no actual use of the frame size in the function body except
> for the debugging prints.  The parameter could be removed if everyone
> who debugs the kernel agrees either to remove the debug code or remove
> the frame pointer from the prints, but it's probably not worth bothering
> about, which is why it's still there.
>
> James
>
>
Ok then , seems its going through I can however write some comments to
explain this
if needed.
Cheers Nick
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/