lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 19 Jul 2014 09:57:08 +0200 From: Joerg Roedel <joro@...tes.org> To: "Rafael J. Wysocki" <rjw@...ysocki.net> Cc: Pavel Machek <pavel@....cz>, Len Brown <len.brown@...el.com>, linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org, Joerg Roedel <jroedel@...e.de> Subject: Re: [PATCH 1/6] PM / Hibernate: Create a Radix-Tree to store memory bitmap On Sat, Jul 19, 2014 at 02:00:39AM +0200, Rafael J. Wysocki wrote: > > +/* > > + * alloc_rtree_node - Allocate a new node and add it to the radix > > + * tree. > > Please make this a single line. > > > +static int add_rtree_block(struct mem_zone_bm_rtree *zone, gfp_t gfp_mask, > > + int safe_needed, struct chain_allocator *ca) > > +{ > > + struct rtree_node *node, *block, **dst; > > + unsigned int levels_needed, block_nr; > > + int i; > > + > > + block_nr = zone->blocks; > > This isn't proper kernel coding style. Please use spaces as separators > before the "=" here and elsewhere. Thanks for your comments, will fix this and resend next week. Joerg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists