lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 19 Jul 2014 12:19:46 +0200 From: Francois Romieu <romieu@...zoreil.com> To: Ethan Zhao <ethan.kernel@...il.com> Cc: Rajesh Borundia <rajesh.borundia@...gic.com>, Ethan Zhao <ethan.zhao@...cle.com>, Manish Chopra <manish.chopra@...gic.com>, Sony Chacko <sony.chacko@...gic.com>, netdev <netdev@...r.kernel.org>, linux-kernel <linux-kernel@...r.kernel.org> Subject: Re: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats() Ethan Zhao <ethan.kernel@...il.com> : > ?? 2014??7??19????????2:21??Rajesh Borundia <rajesh.borundia@...gic.com> ?????? [...] > > I think ethtool stats are adapter specific. Driver does not maintain > > rx_dropped stats and we also don't get it from adapter. I am not > > sure if ethtool stats should match ifconfig stats as ifconfig also > > adds net core stats to adapter stats. > I held the same point as yours before I read more drivers implementation > under Ethernet dir, in fact there is no specification/convention that > ethtool info is adapter specific. All information output by ethtool is > based on the information name itself, one fact we want this patch is > netxen defined 'rx dropped' field but output nothing. It may be fine as a requirement of the day but it does not bode well for the future as ethtool stats API won't get less messy. I'd rather see ethtool stats provides one of those: 1. hardware stats only 2. driver dependent stats - anything you want - as long as the hardware only part of the stats is clearly identified 2. needs works. 1. hurts any requirement where it would priviously had been so easy to add a few lines of code in the driver and push the mess straight from kernel to the end user application. -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists