lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 20 Jul 2014 14:59:57 +0100 From: Jonathan Cameron <jic23@...nel.org> To: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>, Naveen Krishna Ch <naveenkrishna.ch@...il.com> CC: Sachin Kamat <spk.linux@...il.com>, Naveen Krishna Chatradhi <ch.naveen@...sung.com>, linux-iio@...r.kernel.org, linux-samsung-soc <linux-samsung-soc@...r.kernel.org>, "open list:OPEN FIRMWARE AND..." <devicetree@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>, Chanwoo Choi <cw00.choi@...sung.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Lars-Peter Clausen <lars@...afoo.de>, cpgs@...sung.com, Grant Grundler <grundler@...omium.org> Subject: Re: [PATCH 1/4 v2] iio: exyno-adc: use syscon for PMU register access On 17/07/14 14:56, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Thursday, July 17, 2014 05:41:16 PM Naveen Krishna Ch wrote: >> Hello Sachin, >> >> On 17 July 2014 17:24, Sachin Kamat <spk.linux@...il.com> wrote: >>> Hi Naveen, >>> >>> On Thu, Jul 17, 2014 at 4:49 PM, Naveen Krishna Chatradhi >>> <ch.naveen@...sung.com> wrote: >>>> This patch updates the IIO based ADC driver to use syscon and regmap >>>> APIs to access and use PMU registers instead of remapping the PMU >>>> registers in the driver. >>>> >>>> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@...sung.com> >>>> To: linux-iio@...r.kernel.org >>> >>> With only this patch applied, I believe the ADC functionality would be broken. >>> Perhaps the DT changes should be merged along with this patch? >> >> Jonathan already mentioned that, he would wait for Ack from Kukjin. >> With out the dts changes ADC driver will fail to probe but it wont >> crash the system. >> git bisect should still work. > > Unless someone bisects things related to ADC functionality.. > > Also patch #1 seems to break device tree ABI (the old dtb will no longer > work with the new kernel). A very good point. How to avoid this breakage? Supporting the whole old mechanism is going to be a little painful but without that phandle is there any other way? > > Best regards, > -- > Bartlomiej Zolnierkiewicz > Samsung R&D Institute Poland > Samsung Electronics > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists