lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140720040949.GB5875@kroah.com> Date: Sat, 19 Jul 2014 21:09:49 -0700 From: Greg KH <gregkh@...uxfoundation.org> To: Sam Asadi <asadi.samuel@...il.com> Cc: devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/2] Staging: comedi: adv_pci1710.c line over 80 fixed On Sun, Jul 20, 2014 at 04:15:50AM +0300, Sam Asadi wrote: > A line over 80 issue fixed, which is a comment. > > Signed-off-by: Sam Asadi <asadi.samuel@...il.com> > --- > drivers/staging/comedi/drivers/adv_pci1710.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/comedi/drivers/adv_pci1710.c b/drivers/staging/comedi/drivers/adv_pci1710.c > index 602b7a1..13ff78c 100644 > --- a/drivers/staging/comedi/drivers/adv_pci1710.c > +++ b/drivers/staging/comedi/drivers/adv_pci1710.c > @@ -723,7 +723,8 @@ static int pci171x_ai_cancel(struct comedi_device *dev, > devpriv->CntrlReg &= Control_CNT0; > devpriv->CntrlReg |= Control_SW; > > - outw(devpriv->CntrlReg, dev->iobase + PCI171x_CONTROL); /* reset any operations */ > + outw(devpriv->CntrlReg, dev->iobase + PCI171x_CONTROL); > + /* reset any operations */ That really doesn't make any sense now, does it? Please put it _before_ the outw() call. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists