linux-kernel - Re: [PATCH v4 1/6] acerhdf: Adding support for "manual mode"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 20 Jul 2014 12:42:53 +0200
From:	Peter Feuerer <peter@...e.net>
To:	Andreas Mohr <andi@...as.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v4 1/6] acerhdf: Adding support for
         "manual mode"

Hi Andreas,

Andreas Mohr writes:

> Hi
> 
> On Sun, Jul 20, 2014 at 02:51:15AM +0200, Peter Feuerer wrote:
>> @@ -127,105 +138,107 @@ struct bios_settings_t {
>>  	unsigned char fanreg;
>>  	unsigned char tempreg;
>>  	struct fancmd cmd;
>> +	int mcmd_enable;
>>  };
>>  
>> +
>>  /* Register addresses and values for different BIOS versions */
>>  static const struct bios_settings_t bios_tbl[] = {
> 
> Change-unrelated content here, might want to move away.

You mean this newline?


> Suggestion (if ok from a commit revision/history POV):
> git rebase -i s:/'acerhdf: Adding support for "manual mode"'~1
> <"e"dit first commit>
> git checkout -p s:/'acerhdf: Adding support for "manual mode"'
> <grab hunk [split as needed]>
> git commit -m "FIXUP"
> git rebase --continue
> git rebase -i s:/'acerhdf: Adding support for "manual mode"'~1
> <move FIXUP line post [PATCH v4 6/6] acerhdf: minor clean up>
> <do "f"ixup>

If I understand this correctly, you want me to move this new line
to patch 6, correct?


> Sorry that I didn't find worse breakage during my review
> than this si{mp|ng}le line ;)

No problem, as long as you give your Acked-by / Reviewed-by ;)

--peter;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/