linux-kernel - RE: [PATCH v7 07/10] x86, mpx: decode MPX instruction to get bound violation information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9E0BE1322F2F2246BD820DA9FC397ADE016FC1D7@shsmsx102.ccr.corp.intel.com>
Date:	Mon, 21 Jul 2014 06:11:19 +0000
From:	"Ren, Qiaowei" <qiaowei.ren@...el.com>
To:	Andi Kleen <andi@...stfloor.org>
CC:	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"Hansen, Dave" <dave.hansen@...el.com>,
	"x86@...nel.org" <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>
Subject: RE: [PATCH v7 07/10] x86, mpx: decode MPX instruction to get bound
 violation information



On 2014-07-21, Andi Kleen wrote:
> Qiaowei Ren <qiaowei.ren@...el.com> writes:
>> +	 */
>> +#ifdef CONFIG_X86_64
>> +	insn->x86_64 = 1;
>> +	insn->addr_bytes = 8;
>> +#else
>> +	insn->x86_64 = 0;
>> +	insn->addr_bytes = 4;
>> +#endif
> 
> How would that handle compat mode on a 64bit kernel?
> Should likely look at the code segment instead of ifdef.
>> +	/* Note: the upper 32 bits are ignored in 32-bit mode. */
> 
> Again correct for compat mode? I believe the upper bits are undefined.
> 
Compat mode will be supported on next patch in future, as 0/ patch mentioned. ^-^

Thanks,
Qiaowei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/