linux-kernel - Re: [PATCHv7 0/4] iio: adc: exynos_adc: Support Exynos3250 ADC and code clean

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <14522743.f6oFhEQVv4@wuerfel>
Date:	Mon, 21 Jul 2014 09:38:55 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	linux-arm-kernel@...ts.infradead.org
Cc:	Chanwoo Choi <cw00.choi@...sung.com>, jic23@...nel.org,
	ch.naveen@...sung.com, mark.rutland@....com,
	devicetree@...r.kernel.org, kgene.kim@...sung.com,
	pawel.moll@....com, ijc+devicetree@...lion.org.uk,
	linux-iio@...r.kernel.org, t.figa@...sung.com,
	rdunlap@...radead.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
	kyungmin.park@...sung.com, robh+dt@...nel.org, galak@...eaurora.org
Subject: Re: [PATCHv7 0/4] iio: adc: exynos_adc: Support Exynos3250 ADC and code clean

On Monday 21 July 2014 11:17:44 Chanwoo Choi wrote:
> 
> This patchset support Exynos3250 ADC (Analog Digital Converter) because
> Exynos3250 has additional special clock for ADC IP.
> 
> Changes from v6:
> - Use "exynos3250-adc" compatible string instead of "exynos3250-adc-v2"
> - Use "sclk" clock name instead of "sclk_adc"
> - Remove un-necessary macro for exyno-adc-data-v2 structure.
> - Remove '(void *)' cast and mark the exynos-adc-data structure as 'const'
> - Change the number of ADC channels (Exynos3250 has only two channels for ADC)
> 

Looks good to me. Two small requests:

a) if you don't mind, can you add my patch (1/2) to add support for s3c64xx to
   your series, adding your Signed-off-by line in addition to mine? I think
   that one was noncontroversial, while the second patch (2/2) need some more
   work to address the comments and do testing.

b) For the "compatible" string, I think it makes sense to set a fallback to
   "samsung,exynos-adc-v2" in the case for exynos3250, making the DT
   representation

	compatible = "samsung,exynos3250-adc", "samsung,exynos-adc-v2";

   It's not entirely compatible because of the addition of the clock, but
   since the register layout is the same, I think it still make sense.

Thanks.

For the entire series,

Acked-by: Arnd Bergmann <arnd@...db.de>

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/