linux-kernel - Re: [PATCH 2/8] ARM: OMAP2+: timer: Simplify clock event/source name setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 21 Jul 2014 04:05:56 -0700
From:	Tony Lindgren <tony@...mide.com>
To:	Joel Fernandes <joelf@...com>
Cc:	Rob Herring <rob.herring@...xeda.com>,
	Linux OMAP List <linux-omap@...r.kernel.org>,
	Linux ARM Kernel List <linux-arm-kernel@...ts.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/8] ARM: OMAP2+: timer: Simplify clock event/source name
 setting

* Joel Fernandes <joelf@...com> [140422 18:27]:
> For the OMAPs, we're setting up only one clockevent and clocksource. Further,
> for DT boot there's no easy way to get the timer name and currently this is
> done in an ugly way by reading a hwmod entry. So let's just set it to a simpler
> name like timer_clkev and timer_clksrc.
> 
> Signed-off-by: Joel Fernandes <joelf@...com>
> ---
>  arch/arm/mach-omap2/timer.c |   10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c
> index ec427e6..f192a41 100644
> --- a/arch/arm/mach-omap2/timer.c
> +++ b/arch/arm/mach-omap2/timer.c
> @@ -251,7 +251,6 @@ static u32 __init omap_dm_timer_get_errata(void)
>  static int __init omap_dm_timer_init_one(struct omap_dm_timer *timer,
>  					 const char *fck_source,
>  					 const char *property,
> -					 const char **timer_name,
>  					 int posted)
>  {
>  	char name[10]; /* 10 = sizeof("gptXX_Xck0") */
> @@ -290,8 +289,6 @@ static int __init omap_dm_timer_init_one(struct omap_dm_timer *timer,
>  	if (!oh)
>  		return -ENODEV;
>  
> -	*timer_name = oh->name;
> -
>  	if (!of_have_populated_dt()) {
>  		r = omap_hwmod_get_resource_byname(oh, IORESOURCE_IRQ, NULL,
>  						   &irq);
> @@ -365,8 +362,10 @@ static void __init omap2_gp_clockevent_init(int gptimer_id,
>  	 */
>  	__omap_dm_timer_override_errata(&clkev, OMAP_TIMER_ERRATA_I103_I767);
>  
> +	clockevent_gpt.name = "timer_clkev";
> +
>  	res = omap_dm_timer_init_one(&clkev, fck_source, property,
> -				     &clockevent_gpt.name, OMAP_TIMER_POSTED);
> +				     OMAP_TIMER_POSTED);
>  	BUG_ON(res);
>  
>  	omap2_gp_timer_irq.dev_id = &clkev;
> @@ -489,10 +488,11 @@ static void __init omap2_gptimer_clocksource_init(int gptimer_id,
>  	clksrc.errata = omap_dm_timer_get_errata();
>  
>  	res = omap_dm_timer_init_one(&clksrc, fck_source, property,
> -				     &clocksource_gpt.name,
>  				     OMAP_TIMER_NONPOSTED);
>  	BUG_ON(res);
>  
> +	clocksource_gpt.name = "timer_clksrc";
> +
>  	__omap_dm_timer_load_start(&clksrc,
>  				   OMAP_TIMER_CTRL_AR, 0,
>  				   OMAP_TIMER_NONPOSTED);

Hmm aren't we losing information now about which timer we are using?

Might be worth checking if these new names are getting copied somewhere
or what happens after init?

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/