linux-kernel - Re: [PATCH 6/8] ARM: OMAP2+: timer: Fix error message to not use hwmod structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 21 Jul 2014 04:09:02 -0700
From:	Tony Lindgren <tony@...mide.com>
To:	Joel Fernandes <joelf@...com>
Cc:	Rob Herring <rob.herring@...xeda.com>,
	Linux OMAP List <linux-omap@...r.kernel.org>,
	Linux ARM Kernel List <linux-arm-kernel@...ts.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 6/8] ARM: OMAP2+: timer: Fix error message to not use
 hwmod structure

* Joel Fernandes <joelf@...com> [140422 18:27]:
> oh->name is no longer used, correct the error message.

I guess this error is created by one of the patchs in this
series? So maybe fold it into the patch creating this error?

Regards,

Tony
 
> Signed-off-by: Joel Fernandes <joelf@...com>
> ---
>  arch/arm/mach-omap2/timer.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c
> index 4fcfd7a..519ccfd 100644
> --- a/arch/arm/mach-omap2/timer.c
> +++ b/arch/arm/mach-omap2/timer.c
> @@ -331,8 +331,8 @@ static int __init omap_dm_timer_init_one(struct omap_dm_timer *timer,
>  	if (clk_get_parent(timer->fclk) != src) {
>  		r = clk_set_parent(timer->fclk, src);
>  		if (r < 0) {
> -			pr_warn("%s: %s cannot set source\n", __func__,
> -				oh->name);
> +			pr_warn("%s: cannot set timer's source\n", __func__);
> +			WARN_ON(1);
>  			clk_put(src);
>  			return r;
>  		}
> -- 
> 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/