linux-kernel - Re: [PATCH 1/2] ASoC: tas2552: Fix PM sequencing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00FC9A978A94B7418C33AFAE8A35ED49D88593@DFLE09.ent.ti.com>
Date:	Mon, 21 Jul 2014 13:23:17 +0000
From:	"Murphy, Dan" <dmurphy@...com>
To:	Mark Brown <broonie@...nel.org>
CC:	"linux-sound@...r.kernel.org" <linux-sound@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>
Subject: Re: [PATCH 1/2] ASoC: tas2552: Fix PM sequencing

Mark

On 07/21/2014 07:19 AM, Mark Brown wrote:
> On Fri, Jul 18, 2014 at 12:31:07PM -0500, Dan Murphy wrote:
>> In the pm suspend/resume it is better
>> to disable the GPIO after the regmap_cache
>> setting calls so that if the call is interrupted
>> the new reg values will be cached and set on resume.
>>
>> Also add pm_runtime_put in the remove call.
> Applied, thanks, but please don't mix multiple changes into one commit
> like this especially when there's no textual overlap.

I usually don't mix changes like this as I like to have a single change per
commit.

But I find each maintainer is a little different but now I know for next time.

Thanks

-- 
------------------
Dan Murphy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/