lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 21 Jul 2014 03:18:24 +0200 From: "Rafael J. Wysocki" <rjw@...ysocki.net> To: Bjorn Helgaas <bhelgaas@...gle.com> Cc: Linux PCI <linux-pci@...r.kernel.org>, Linux PM list <linux-pm@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Huang Ying <huang.ying.caritas@...il.com> Subject: [Update][PATCH] PCI / PM: Allow PCI devices to be put into D3cold during system suspend From: Rafael J. Wysocki <rafael.j.wysocki@...el.com> Commit 448bd857d48e (PCI/PM: add PCIe runtime D3cold support) added a check to prevent PCI devices from being put into D3cold during system suspend without giving any particular reason. Also the check isn't really necessary, because acpi_pci_set_power_state() maps PCI_D3hot to ACPI_STATE_D3_COLD anyway. Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com> --- Ying notices that acpi_pci_set_power_state() maps PCI D3hot to ACPI D3cold, so the check actually isn't effective even, but that means that the second part of my original changelog was in fact incorrect. --- drivers/pci/pci.c | 4 ---- 1 file changed, 4 deletions(-) Index: linux-pm/drivers/pci/pci.c =================================================================== --- linux-pm.orig/drivers/pci/pci.c +++ linux-pm/drivers/pci/pci.c @@ -1907,10 +1907,6 @@ int pci_prepare_to_sleep(struct pci_dev if (target_state == PCI_POWER_ERROR) return -EIO; - /* D3cold during system suspend/hibernate is not supported */ - if (target_state > PCI_D3hot) - target_state = PCI_D3hot; - pci_enable_wake(dev, target_state, device_may_wakeup(&dev->dev)); error = pci_set_power_state(dev, target_state); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists