lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1405954117.6962.37.camel@rhapsody> Date: Mon, 21 Jul 2014 08:48:37 -0600 From: Khalid Aziz <khalid@...ehiking.org> To: Benoit Taine <benoit.taine@...6.fr> Cc: "James E.J. Bottomley" <JBottomley@...allels.com>, linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/25] BusLogic: Replace DEFINE_PCI_DEVICE_TABLE macro use On Fri, 2014-07-18 at 17:26 +0200, Benoit Taine wrote: > We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet > kernel coding style guidelines. This issue was reported by checkpatch. > > Signed-off-by: Benoit Taine <benoit.taine@...6.fr> > > --- > Tested by compilation without errors. > > drivers/scsi/BusLogic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c > index 972f817..64c7514 100644 > --- a/drivers/scsi/BusLogic.c > +++ b/drivers/scsi/BusLogic.c > @@ -3893,7 +3893,7 @@ __setup("BusLogic=", blogic_setup); > PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0}, > { } > };*/ > -static DEFINE_PCI_DEVICE_TABLE(blogic_pci_tbl) = { > +static const struct pci_device_id blogic_pci_tbl[] = { > {PCI_DEVICE(PCI_VENDOR_ID_BUSLOGIC, PCI_DEVICE_ID_BUSLOGIC_MULTIMASTER)}, > {PCI_DEVICE(PCI_VENDOR_ID_BUSLOGIC, PCI_DEVICE_ID_BUSLOGIC_MULTIMASTER_NC)}, > {PCI_DEVICE(PCI_VENDOR_ID_BUSLOGIC, PCI_DEVICE_ID_BUSLOGIC_FLASHPOINT)}, > Acked-by: Khalid Aziz <khalid@...ehiking.org> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists