linux-kernel - Re: high cpu load on omap3 using musb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3341916.JePQu0RYOt@avalon>
Date:	Mon, 21 Jul 2014 17:28:58 +0200
From:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:	Adam Wozniak <awozniak@...bot.com>
Cc:	linux-kernel@...r.kernel.org, linux-arm@...ts.infradead.org,
	linux-usb@...r.kernel.org, "Agius, Frank" <fagius@...bot.com>,
	Felipe Balbi <balbi@...com>
Subject: Re: high cpu load on omap3 using musb

Hi Adam,

On Wednesday 29 January 2014 08:44:57 Adam Wozniak wrote:
> With a USB 2.0 webcam attached to the OTG port on an OMAP3 (applies to
> overo gumstix, beagleboard, probably others) we see a high CPU load in a
> kworker thread.
> 
> Between 2.6.33 and 2.6.34 musb_core.c changed.
> 
> IRQ handlers changed with the result that a worker in musb_core.c got
> scheduled far more frequently than needed.
> 
> I've included a patch below against 3.7, but i think it'll apply against
> mainline.
> [I apologize for any whitespace mangling.  I've also attached the patch.]
> 
> I'd like more eyeballs to tell me if this is right.  I'd also like to
> know who I need to talk to to get this pushed into mainline.

Running the scripts/get_maintainer.pl script on your patch produces

Felipe Balbi <balbi@...com> (maintainer:MUSB MULTIPOINT H...)
Greg Kroah-Hartman <gregkh@...uxfoundation.org> (supporter:USB SUBSYSTEM)
linux-usb@...r.kernel.org (open list:MUSB MULTIPOINT H...)
linux-kernel@...r.kernel.org (open list)

Felipe Balbi (CC'ed) is the person who you should talk to.

While we're touching the subject of scripts, you should run the 
scripts/checkpatch.pl script and fix errors and warnings before submitting 
patches. Please see Documentation/SubmittingPatches.

Last (but not least) piece of advice, don't give up if you don't receive 
replies to your patches. People are busy and mails fall to cracks from time to 
time.

Felipe, apart from the coding style violation and the possibly missing 
locking, what's your opinion on this ? Does the patch make sense ?

> # The MUSB IRQ schedules work on every interrupt.
> # This is unnecessary, and causes excessive CPU load.
> #
> # Here we only schedule work if there is something for
> # the worker to do.
> 
> Index: git/drivers/usb/musb/musb_core.c
> ===================================================================
> --- git.orig/drivers/usb/musb/musb_core.c
> +++ git/drivers/usb/musb/musb_core.c
> @@ -925,7 +925,9 @@ b_host:
>          }
>   #endif
> 
> -       schedule_work(&musb->irq_work);
> +       if (musb->xceiv->state != musb->xceiv_old_state) {
> +               schedule_work(&musb->irq_work);
> +       }
> 
>          return handled;
>   }

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/