lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20140720.205830.595868255699983537.davem@davemloft.net> Date: Sun, 20 Jul 2014 20:58:30 -0700 (PDT) From: David Miller <davem@...emloft.net> To: ethan.zhao@...cle.com Cc: manish.chopra@...gic.com, sony.chacko@...gic.com, rajesh.borundia@...gic.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, ethan.kernel@...il.com Subject: Re: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats() From: Ethan Zhao <ethan.zhao@...cle.com> Date: Fri, 18 Jul 2014 11:43:29 +0800 > netxen driver has implemented netxen_nic_get_ethtool_stats() interface, > but it doesn't collect stats.rxdropped in driver, so we will get > different rx_dropped statistic information while using ifconfig and ethtool. > this patch fills stats.rxdropped field with data from net core > with dev_get_stats() just as ixgbe driver did for some of its stats. > > Tested with last netxen 4.0.82 > Compiled with stable 3.15.6 > > Signed-off-by: Ethan Zhao <ethan.zhao@...cle.com> > Tested-by: Sriharsha Yadagudde <sriharsha.devdas@...cle.com> ethtool stats are _NOT_ the place to duplicate normal netdev stats, PERIOD. The only exception is when you maintainer per-queue instaces of these stats, and want to export that information to the user. I'm not applying this, sorry. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists