linux-kernel - Re: [PATCH 6/7] firmware_class: add "fd" input file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140721163646.GA14431@kroah.com>
Date:	Mon, 21 Jul 2014 09:36:46 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Kees Cook <kees@...flux.net>
Cc:	Kees Cook <keescook@...omium.org>,
	Ming Lei <ming.lei@...onical.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"Luis R. Rodriguez" <mcgrof@...e.com>,
	James Morris <james.l.morris@...cle.com>,
	David Howells <dhowells@...hat.com>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	linux-security-module <linux-security-module@...r.kernel.org>,
	linux-firmware@...nel.org,
	linux-wireless <linux-wireless@...r.kernel.org>
Subject: Re: [PATCH 6/7] firmware_class: add "fd" input file

On Mon, Jul 21, 2014 at 08:43:07AM -0700, Kees Cook wrote:
> On Mon, Jul 21, 2014 at 08:26:35AM -0700, Greg Kroah-Hartman wrote:
> > On Mon, Jul 21, 2014 at 08:08:16AM -0700, Kees Cook wrote:
> > > Perhaps it would be easier if I also sent the patch to udev's helper,
> > > so you could see how I propose handling the userspace change to using
> > > the new interface?
> > 
> > As there is no more "udev firmware helper", I don't know what you would
> > be patching here.  Firmware should always be loaded by the kernel
> > directly, udev isn't involved anyore at all.
> > 
> > confused,
> > 
> > greg k-h
> 
> The kernel _can_ load directly (when the paths are configured correctly),
> but I'm not sure why you say udev isn't involved any more. It's been like
> this for years, and even the latest systemd shows the udev rule is still in
> place:
> http://cgit.freedesktop.org/systemd/systemd/tree/rules/50-firmware.rules
> and that the firmware loader is still in the source tree:
> http://cgit.freedesktop.org/systemd/systemd/tree/src/udev/udev-builtin-firmware.c

Ah, I thought that I had seen patches to delete this code on the systemd
mailing list in the past, I didn't realize they hadn't been accepted
yet.

But, with my current tree, in linux-next, it's really hard to select the
"external firmware loader" on purpose, as we want people to use the
in-kernel one if at all possible, and only fall back to the "legacy"
udev userspace loader if they are running on old userspace systems.

> Here's the patch for the new interface...

I'd really not like to add a new interface for this model when we are
trying to delete it entirely.  Why not just rely on the in-kernel loader
instead for this new feature?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/