linux-kernel - Re: [PATCH 3/4] drivers/misc/sgi-gru/grukdump.c: drop negativity check for unsgined req.gid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140721201209.GA19927@sgi.com>
Date:	Mon, 21 Jul 2014 15:12:09 -0500
From:	Dimitri Sivanich <sivanich@....com>
To:	Andrey Utkin <andrey.krieger.utkin@...il.com>
Cc:	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 3/4] drivers/misc/sgi-gru/grukdump.c: drop negativity
 check for unsgined req.gid

Acked-by: Dimitri Sivanich <sivanich@....com>

On Thu, Jul 17, 2014 at 04:55:07PM +0300, Andrey Utkin wrote:
> [linux-3.16-rc5/drivers/misc/sgi-gru/grukdump.c:199]: (style) Checking if
> unsigned variable 'gid' is less than zero.
> 
>     if (req.gid >= gru_max_gids || req.gid < 0)
>         return -EINVAL;
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80461
> Reported-by: David Binderman <dcb314@...mail.com>
> Signed-off-by: Andrey Utkin <andrey.krieger.utkin@...il.com>
> ---
>  drivers/misc/sgi-gru/grukdump.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/sgi-gru/grukdump.c b/drivers/misc/sgi-gru/grukdump.c
> index a3700a5..e0e0e7e 100644
> --- a/drivers/misc/sgi-gru/grukdump.c
> +++ b/drivers/misc/sgi-gru/grukdump.c
> @@ -196,7 +196,7 @@ int gru_dump_chiplet_request(unsigned long arg)
>  		return -EFAULT;
>  
>  	/* Currently, only dump by gid is implemented */
> -	if (req.gid >= gru_max_gids || req.gid < 0)
> +	if (req.gid >= gru_max_gids)
>  		return -EINVAL;
>  
>  	gru = GID_TO_GRU(req.gid);
> -- 
> 1.8.5.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/