| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140721212527.GC3824@amd.pavel.ucw.cz> Date: Mon, 21 Jul 2014 23:25:27 +0200 From: Pavel Machek <pavel@....cz> To: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> Cc: Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>, Tomi Valkeinen <tomi.valkeinen@...com>, Rickard Strandqvist <rickard.strandqvist@...ymobile.com>, Wang YanQing <udknight@...il.com>, Jingoo Han <jg1.han@...sung.com>, Evgeniy Polyakov <zbr@...emap.net>, Joe Perches <joe@...ches.com>, Sachin Kamat <sachin.kamat@...aro.org>, David Fries <David@...es.net>, linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] video: fbdev: uvesafb.c: Cleaning up variable that is never used On Sat 2014-07-05 14:51:22, Rickard Strandqvist wrote: > From: Rickard Strandqvist <rickard.strandqvist@...ymobile.com> > > Variable ar assigned a value that is never used. > I have also removed all the code that thereby serves no purpose. > > This was found using a static code analysis program called cppcheck Are you sure this is right fix? Should we be returning the error when there's error? -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists