linux-kernel - Re: [PATCH] x86_32, entry: store badsys error code in %eax

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALCETrU8xTGpOWONMnByAQo5TAqzutguw+L5_QW8K_iDe0EyeQ@mail.gmail.com>
Date:	Mon, 21 Jul 2014 14:59:58 -0700
From:	Andy Lutomirski <luto@...capital.net>
To:	Sven Wegener <sven.wegener@...aler.net>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	Richard Weinberger <richard@....at>, X86 ML <x86@...nel.org>,
	Eric Paris <eparis@...hat.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Borislav Petkov <bp@...en8.de>,
	Toralf Förster <toralf.foerster@....de>,
	stable <stable@...r.kernel.org>,
	Roland McGrath <roland@...hat.com>,
	Josh Boyer <jwboyer@...oraproject.org>
Subject: Re: [PATCH] x86_32, entry: store badsys error code in %eax

On Sun, Jul 20, 2014 at 2:33 PM, Sven Wegener <sven.wegener@...aler.net> wrote:
> Commit 554086d ("x86_32, entry: Do syscall exit work on badsys
> (CVE-2014-4508)") introduced a subtle regression in the x86_32 syscall
> entry code, resulting in syscall() not returning proper errors for
> non-existing syscalls on CPUs not supporting the sysenter feature.

s/not supporting/supporting/

That means that this is IMO much worse than the other way around: all
newish 32-bit systems are affected.

Other than the typo and the missing Cc: stable:

Reviewed-and-tested-by: Andy Lutomirski <luto@...capital.net>

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/