linux-kernel - Re: [PATCH] cpuidle: fix permission for driver name sysfs node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1636314.JDKxdToLsi@vostro.rjw.lan>
Date:	Wed, 23 Jul 2014 01:54:35 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Mohammad Merajul Islam Molla <meraj.enigma@...il.com>
Cc:	linux-pm@...r.kernel.org, daniel.lezcano@...aro.org,
	linux-kernel@...r.kernel.org, linaro-kernel@...ts.linaro.org
Subject: Re: [PATCH] cpuidle: fix permission for driver name sysfs node

On Saturday, July 12, 2014 07:29:22 PM Mohammad Merajul Islam Molla wrote:
> cpuidle driver name sysfs node is read-only. So permission should be 0444.
> 
> Signed-off-by: Mohammad Merajul Islam Molla <meraj.enigma@...il.com>

Queued up for 3.17, thanks!

> ---
>  drivers/cpuidle/sysfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpuidle/sysfs.c b/drivers/cpuidle/sysfs.c
> index efe2f17..97c5903 100644
> --- a/drivers/cpuidle/sysfs.c
> +++ b/drivers/cpuidle/sysfs.c
> @@ -445,7 +445,7 @@ static void cpuidle_remove_state_sysfs(struct cpuidle_device *device)
>  
>  #define define_one_driver_ro(_name, show)                       \
>  	static struct cpuidle_driver_attr attr_driver_##_name = \
> -		__ATTR(_name, 0644, show, NULL)
> +		__ATTR(_name, 0444, show, NULL)
>  
>  struct cpuidle_driver_kobj {
>  	struct cpuidle_driver *drv;
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/