linux-kernel - Re: [PATCH] extcon: arizona: Get MICVDD against extcon device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <53CDF2C7.3070705@samsung.com>
Date:	Tue, 22 Jul 2014 14:12:39 +0900
From:	Chanwoo Choi <cw00.choi@...sung.com>
To:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
Cc:	myungjoo.ham@...sung.com, patches@...nsource.wolfsonmicro.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] extcon: arizona: Get MICVDD against extcon device

On 07/18/2014 08:59 PM, Charles Keepax wrote:
> Previously we would do a regulator get against the main Arizona device
> to obtain the MICVDD regulator. Arizona is an MFD device and normally
> MICVDD will be supplied by one of its children (the arizona-micsupp
> regulator). As devres destruction for the MFD device will run after all
> its children have been destroyed, the regulator will be destroyed before
> devres calls regulator_put. This causes a warning from both the
> destruction of the child node, as the regulator is still open, and from
> the put of the regulator as the regulator device has already been
> destroyed.
> 
> A simple fix here is to get the regulator against the extcon device
> itself such that devres runs when the child is destroyed. This has the
> additional benefit that if for some reason the extcon driver is unloaded
> the regulator reference won't hang around until the MFD is unloaded.
> 
> Signed-off-by: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>

Applied now, Thanks.

Chanwoo Choi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/