linux-kernel - Re: [PATCH] spin_lock_*(): Always evaluate second argument

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1407211747090.7042@chino.kir.corp.google.com>
Date:	Mon, 21 Jul 2014 17:47:25 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Bart Van Assche <bvanassche@....org>
cc:	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	"David S. Miller" <davem@...emloft.net>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] spin_lock_*(): Always evaluate second argument

On Mon, 16 Jun 2014, Bart Van Assche wrote:

> Evaluating a macro argument only if certain configuration options
> have been selected is confusing and error-prone. Hence always
> evaluate the second argument of spin_lock_nested() and
> spin_lock_nest_lock().
> 
> This patch has the intentional side effect that it avoids that the
> following warning is reported for netif_addr_lock_nested() when
> building with CONFIG_DEBUG_LOCK_ALLOC=n and with W=1:
> 
> include/linux/netdevice.h: In function 'netif_addr_lock_nested':
> include/linux/netdevice.h:2865:6: warning: variable 'subclass' set but not used [-Wunused-but-set-variable]
>   int subclass = SINGLE_DEPTH_NESTING;
>       ^
> 
> Signed-off-by: Bart Van Assche <bvanassche@....org>
> Cc: Ingo Molnar <mingo@...nel.org>
> Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Cc: David S. Miller <davem@...emloft.net>

Bart, could you please resend this patch with my acked-by?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/