linux-kernel - Re: [PATCH] cleanup include/asm-generic/atomic.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1407211707510.5825@chino.kir.corp.google.com>
Date:	Mon, 21 Jul 2014 17:08:11 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Madhavan Srinivasan <maddy@...ux.vnet.ibm.com>
cc:	arnd@...db.de, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cleanup include/asm-generic/atomic.h

On Tue, 22 Jul 2014, Madhavan Srinivasan wrote:

> Commit 4b358e2206 "cleanup include/asm-generic/atomic.h" added
> comments for #else/#endif, but ended up adding same comment
> "BITS_PER_LONG == 64" on both sides. This patch fixes it.
> 

It's intentionally like that, it comments the condition for which the 
#endif is matched.

> Signed-off-by: Madhavan Srinivasan <maddy@...ux.vnet.ibm.com>
> ---
>  include/asm-generic/atomic-long.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/asm-generic/atomic-long.h b/include/asm-generic/atomic-long.h
> index b7babf0..a8434c6 100644
> --- a/include/asm-generic/atomic-long.h
> +++ b/include/asm-generic/atomic-long.h
> @@ -253,6 +253,6 @@ static inline long atomic_long_add_unless(atomic_long_t *l, long a, long u)
>  #define atomic_long_xchg(v, new) \
>  	(atomic_xchg((atomic_t *)(v), (new)))
>  
> -#endif  /*  BITS_PER_LONG == 64  */
> +#endif  /*  BITS_PER_LONG != 64  */
>  
>  #endif  /*  _ASM_GENERIC_ATOMIC_LONG_H  */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/