lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140722074721.GM25880@mwanda> Date: Tue, 22 Jul 2014 10:47:21 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: Andrey Utkin <andrey.krieger.utkin@...il.com> Cc: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org, kgdb-bugreport@...ts.sourceforge.net, dcb314@...mail.com, jason.wessel@...driver.com Subject: Re: [PATCH 4/5] kernel/debug/kdb/kdb_bp.c: drop negativity check on unsigned value On Fri, Jul 18, 2014 at 06:34:52PM +0300, Andrey Utkin wrote: > static char *kdb_bptype(kdb_bp_t *bp) > { > - if (bp->bp_type < 0 || bp->bp_type > 4) > + if (bp->bp_type > 4) > return ""; With Smatch, I ignore negative checks in this format. It's obvious what the intent is and they are harmless. Patching them requires a little review to make sure that someone isn't introducing a bug and can't be done directly in the email client. On the other hand, in Smatch I do complain about checks like: if (bp->bp_type > 4 || bp->bp_type < 0) Because only backwards thinking people write checks like that. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists