linux-kernel - Re: [PATCH] video: fbdev: uvesafb.c: Cleaning up variable that is never used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140722092757.GA8796@amd.pavel.ucw.cz>
Date:	Tue, 22 Jul 2014 11:27:57 +0200
From:	Pavel Machek <pavel@....cz>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc:	Joe Perches <joe@...ches.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Tomi Valkeinen <tomi.valkeinen@...com>,
	Sachin Kamat <sachin.kamat@...aro.org>,
	Evgeniy Polyakov <zbr@...emap.net>,
	Wang YanQing <udknight@...il.com>,
	Rickard Strandqvist <rickard.strandqvist@...ymobile.com>,
	Jingoo Han <jg1.han@...sung.com>,
	Linux Fbdev development list <linux-fbdev@...r.kernel.org>,
	David Fries <David@...es.net>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] video: fbdev: uvesafb.c: Cleaning up variable that is
 never used

On Tue 2014-07-22 11:16:58, Rickard Strandqvist wrote:
> Hi
> 
> Sure, I agree. But as I thought that I would not change
> currentfunctionality, I would increase the chance that the patches were
> included. And it would of course also clarify this type of problem.

I'm trying to say that getting rid of the variables without changing
functionality might be wrong thing to do, for example in this case. It
looks like error handing is missing by mistake, and you are removing
traces saying that error handing is required here.

Dunno. Perhaps don't push patches where solution is not obvious?

Or push them but mark the place with fixme? 

									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/