[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <53CE4B1F.9080701@gmail.com>
Date: Tue, 22 Jul 2014 19:29:35 +0800
From: Chen Gang <gang.chen.5i5j@...il.com>
To: Arnd Bergmann <arnd@...db.de>
CC: Lennox Wu <lennox.wu@...il.com>,
Richard Weinberger <richard@....at>,
Lars-Peter Clausen <lars@...afoo.de>,
Guenter Roeck <linux@...ck-us.net>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Dmitry Torokhov <dmitry.torokhov@...il.com>,
linux-iio@...r.kernel.org,
Benjamin Herrenschmidt <benh@...nel.crashing.org>,
Tom Gundersen <teg@...m.no>,
Thierry Reding <thierry.reding@...il.com>,
Marek Vasut <marex@...x.de>,
Liqin Chen <liqin.linux@...il.com>, msalter@...hat.com,
linux-pwm@...r.kernel.org, devel@...verdev.osuosl.org,
linux-watchdog@...r.kernel.org, linux-input@...r.kernel.org,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
knaack.h@....de, Martin Schwidefsky <schwidefsky@...ibm.com>,
jic23@...nel.org, Geert Uytterhoeven <geert@...ux-m68k.org>,
cmetcalf@...era.com, heiko.carstens@...ibm.com
Subject: Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for
'devm_ioremap_resource'
On 07/22/2014 06:32 PM, Arnd Bergmann wrote:
> On Sunday 20 July 2014 17:45:40 Chen Gang wrote:
>>>
>>> Next, I shall:
>>>
>>> - Remove HAS_IOMEM and NO_IOMEM from kernel, firstly.
>>>
>>> - Try to make dummy IOMEM functions for score architecture.
>>>
>>> - Continue discussing with UML for it.
>>>
>>
>> Oh, sorry, I forgot, after remove IOMEM from kernel, also s390 and tile
>> need implement dummy IOMEM if !PCI.
>>
>> If possible, I shall try to implement the dummy IOMEM in 'asm-generic',
>> and let uml, score, s390 and tile use them when they need.
>
> Sorry for going round in circles, but looking back at the original patches,
> adding the extra 'depends on HAS_IOMEM' does seem much better than the
> other suggestions that came afterwards.
>
> In particular, removing HAS_IOMEM and NO_IOMEM sounds like an awful idea
> to me. I'd rather add a HAS_IOPORT in addition to also catch architectures
> that have no support for PC-style PIO.
>
Welcome any other members (especially driver members) ideas and
suggestions -- driver members and architecture members have different
tastes and different roles.
For me, if no additional reply, I prefer to keep current status, and
still add 'depends on HAS_IOMEM' for each driver which need it, but I am
not sure whether driver members can bear it.
Thanks.
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists