lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140722121556.GC16065@lee--X1> Date: Tue, 22 Jul 2014 13:15:56 +0100 From: Lee Jones <lee.jones@...aro.org> To: pramod gurav <pramod.gurav.etc@...il.com> Cc: "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Samuel Ortiz <sameo@...ux.intel.com> Subject: Re: [PATCH 02/19] mfd: max8925-i2c: Fix 'blank line after declarations' warning On Tue, 22 Jul 2014, pramod gurav wrote: > On Tue, Jul 22, 2014 at 4:41 PM, Lee Jones <lee.jones@...aro.org> wrote: > > This is part of an effort to clean-up the MFD subsystem. > > > > WARNING: Missing a blank line after declarations > > + int ret; > > + ret = i2c_add_driver(&max8925_driver); > > > > total: 0 errors, 1 warnings, 275 lines checked > > > > Signed-off-by: Lee Jones <lee.jones@...aro.org> > > --- > > drivers/mfd/max8925-i2c.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/mfd/max8925-i2c.c b/drivers/mfd/max8925-i2c.c > > index a83eed5..ecbe78e 100644 > > --- a/drivers/mfd/max8925-i2c.c > > +++ b/drivers/mfd/max8925-i2c.c > > @@ -257,9 +257,11 @@ static struct i2c_driver max8925_driver = { > > static int __init max8925_i2c_init(void) > > { > > int ret; > > + > > ret = i2c_add_driver(&max8925_driver); > > if (ret != 0) > > pr_err("Failed to register MAX8925 I2C driver: %d\n", ret); > > + > There are more such changes required in this file. If they could go > with this, will be good. Checkpatch only found this one: > WARNING: Missing a blank line after declarations > #260: FILE: drivers/mfd/max8925-i2c.c:260: > + int ret; > + ret = i2c_add_driver(&max8925_driver); > > total: 0 errors, 1 warnings, 275 lines checked Can you point me to the others please? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists