lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140722125820.GO25880@mwanda> Date: Tue, 22 Jul 2014 15:58:20 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: Fabio Falzoi <fabio.falzoi84@...il.com> Cc: gregkh@...uxfoundation.org, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org, wei_wang@...lsil.com.cn, joe@...ches.com Subject: Re: [PATCH v4 1/3] Staging: rts5208: Replace custom macro with dev_dbg On Mon, Jul 21, 2014 at 11:36:02PM +0200, Fabio Falzoi wrote: > @@ -3664,7 +3672,7 @@ static int mg_set_tpc_para_sub(struct rtsx_chip *chip, int type, > int retval; > u8 buf[6]; > > - RTSX_DEBUGP("--%s--\n", __func__); > + dev_dbg(rtsx_dev(chip), "--%s--\n", __func__); All of these debug printks to mark when we have called a function should be deleted. We have ftrace for that. > -static inline void free_zone(struct zone_entry *zone) > +static inline void free_zone(const struct rtsx_chip *chip, > + struct zone_entry *zone) > { > - RTSX_DEBUGP("free_zone\n"); > + dev_dbg(rtsx_dev(chip), "free_zone\n"); > > if (!zone) > return; Don't add a parameter to free_zone() just for this debug printk which should be deleted. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists