lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140722131832.GY8537@dragon> Date: Tue, 22 Jul 2014 21:18:33 +0800 From: Shawn Guo <shawn.guo@...escale.com> To: Stefan Agner <stefan@...er.ch> CC: <peter.chen@...escale.com>, <s.hauer@...gutronix.de>, <b35083@...escale.com>, <linux-arm-kernel@...ts.infradead.org>, <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 1/6] ARM: dts: vf610: add USB PHY and controller On Tue, Jul 22, 2014 at 11:57:31AM +0200, Stefan Agner wrote: > Am 2014-07-22 04:22, schrieb Shawn Guo: > > On Fri, Jul 18, 2014 at 07:01:37PM +0200, Stefan Agner wrote: > >> This adds USB PHY and USB controller nodes. Vybrid SoCs have two > >> independent USB cores which each supports DR (dual role). However, > >> real OTG is not supported since the OTG ID pin is not available. > >> > >> The PHYs are located within the anadig register range, hence we need > >> to change the length of the anadig registers. > >> > >> Signed-off-by: Stefan Agner <stefan@...er.ch> > >> --- > >> arch/arm/boot/dts/vf610.dtsi | 46 +++++++++++++++++++++++++++++++++++++++++--- > >> 1 file changed, 43 insertions(+), 3 deletions(-) > >> > >> diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi > >> index 6a6190c..f6c3f02 100644 > >> --- a/arch/arm/boot/dts/vf610.dtsi > >> +++ b/arch/arm/boot/dts/vf610.dtsi > >> @@ -25,6 +25,8 @@ > >> gpio2 = &gpio3; > >> gpio3 = &gpio4; > >> gpio4 = &gpio5; > >> + usbphy0 = &usbphy0; > >> + usbphy1 = &usbphy1; > >> }; > >> > >> cpus { > >> @@ -285,9 +287,25 @@ > >> gpio-ranges = <&iomuxc 0 128 7>; > >> }; > >> > >> - anatop@...50000 { > >> - compatible = "fsl,vf610-anatop"; > >> - reg = <0x40050000 0x1000>; > >> + anatop: anatop@...50000 { > >> + compatible = "fsl,vf610-anatop", "syscon"; > >> + reg = <0x40050000 0x400>; > >> + }; > >> + > >> + usbphy0: usbphy@...50800 { > >> + compatible = "fsl,vf610-usbphy", "fsl,imx23-usbphy"; > > > > Since phy driver will match "fsl,vf610-usbphy" anyway, we do not need > > "fsl,imx23-usbphy" here. > > <snip> > > >> @@ -309,6 +327,18 @@ > >> reg = <0x4006b000 0x1000>; > >> #clock-cells = <1>; > >> }; > >> + > >> + usbdev0: usb@...34000 { > >> + compatible = "fsl,imx6q-usb", "fsl,imx27-usb"; > > > > It doesn't really make any sense to have "fsl,imx6q-usb" here. The > > following one should be less confusing. > > > > compatible = "fsl,vf610-usb", "fsl,imx27-usb"; > > > I don't quite understand the rule here, when do we drop compatible you > suggest in fsl,imx23-usbphy and when do we keep the "fallback" as we do > for the USB controller? > > Documentation/devicetree/bindings/usb/mxs-phy.txt says: > > "fsl,imx23-usbphy" is still a fallback for other strings As "fsl,vf610-usbphy" should be added into mxs-phy.txt as a new compatible string, "fsl,imx23-usbphy" will not be the "fallback" of it, so there is no point to have "fsl,imx23-usbphy" for vf610 usbphy. > > And Documentation/devicetree/bindings/usb/ci-hdrc-imx.txt says: > > - compatible: Should be "fsl,imx27-usb" The "fsl,imx27-usb" is the only compatible string defined by the binding, and vf610 usb will also match it, so we need to have it in the vf610 usb compatible string. "fsl,vf610-usb" is put there only for saving DTB update in case someday vf610 usb needs a new programming model and the binding needs to be extended to have "fsl,vf610-usb" as a new compatible. Shawn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists