lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <53CE65F3.9050004@intel.com> Date: Tue, 22 Jul 2014 16:24:03 +0300 From: Adrian Hunter <adrian.hunter@...el.com> To: Jiri Olsa <jolsa@...hat.com> CC: Arnaldo Carvalho de Melo <acme@...nel.org>, Peter Zijlstra <peterz@...radead.org>, David Ahern <dsahern@...il.com>, Frederic Weisbecker <fweisbec@...il.com>, Namhyung Kim <namhyung@...il.com>, Paul Mackerras <paulus@...ba.org>, Stephane Eranian <eranian@...gle.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH V3] perf tools: Record whether a dso has data On 07/22/2014 10:55 AM, Jiri Olsa wrote: > On Thu, Jul 17, 2014 at 11:58:30AM +0300, Adrian Hunter wrote: >> Add 'data_status' to record whether a dso has data >> (i.e. an object file) > > I might have seen it in your last patsent, but forgot.. what is > this data_status going to be used for? I have changed it a bit in the latest posting. It was originally for two purposes: 1. to prevent repeatedly attempting to open a file that was not there (very time consuming if you do it millions of times) 2. to report the error exactly once But I realized it did not meet the 2nd objective so I have added another patch that does. See "perf tools: Add dso__data_status_seen()" > > SNIP > >> diff --git a/tools/perf/util/dso.h b/tools/perf/util/dso.h >> index c239e86..07d0a58 100644 >> --- a/tools/perf/util/dso.h >> +++ b/tools/perf/util/dso.h >> @@ -40,6 +40,12 @@ enum dso_swap_type { >> DSO_SWAP__YES, >> }; >> >> +enum dso_data_status { >> + DSO_DATA_STATUS_ERROR = -1, >> + DSO_DATA_STATUS_UNKNOWN = 0, >> + DSO_DATA_STATUS_OK = 1, >> +}; >> + >> #define DSO__SWAP(dso, type, val) \ >> ({ \ >> type ____r = val; \ >> @@ -104,6 +110,7 @@ struct dso { >> struct { >> struct rb_root cache; >> int fd; >> + int data_status; > > also please call it just 'status' it's already in 'data' struct I made that change too. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists